Fix a couple of UB issues.#95
Merged
twarit-waikar merged 3 commits intosalesforce:masterfrom Feb 18, 2026
Merged
Conversation
|
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Dmitrii Kuragin <d***@A***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated. |
|
Thanks for the contribution! Before we can merge this, we need @sstepashka to sign the Salesforce Inc. Contributor License Agreement. |
When the given repo has list of files nore than the cache limit, it's being evicted from RAM and adding new file into the index requires recalculation for every add command.
Contributor
Author
I can't sign it harder :) |
Contributor
|
This is amazing, thanks for sending this in! I will try to find what's up with the CI but I tested this locally and things seem to work. Thanks again! |
twarit-waikar
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issues described in #92:
main.ccis detected by ASAN, when compilep4-fusionwith-fsanitiezer=address, it would trigger the issue immediately.ClientUser. Seems like p4api is not designed to be copyable ever.An alternative solution would be not to inherit from
ClientUserfor the data models and add a layer where we convert things, but it might require more work to separate it.